fix bug that was dropping the last category from nominals

interpretml · Jan 6, 2025 · e0bcadd · e0bcadd
1 parent 15a600d
commit e0bcadd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/shared/libebm/PartitionOneDimensionalBoosting.cpp b/shared/libebm/PartitionOneDimensionalBoosting.cpp
@@ -1175,14 +1175,15 @@ template<bool bHessian, size_t cCompilerScores> class PartitionOneDimensionalBoo
             auto** const ppBinShuffleEnd = apBins + cKeep;
             do {
                EBM_ASSERT(1 <= cRemaining);
-               if(1 == cRemaining) {
-                  break; // it will always be zero
+               if(1 != cRemaining) {
+                  const size_t iSwap = pRng->NextFast(cRemaining);
+                  auto* const pTemp = ppBinShuffle[iSwap];
+                  --cRemaining;
+                  ppBinShuffle[iSwap] = *ppBinShuffle;
+                  *ppBinShuffle = pTemp;
+               } else {
+                  EBM_ASSERT(ppBinShuffleEnd == ppBinShuffle + 1);
                }
-               const size_t iSwap = pRng->NextFast(cRemaining);
-               auto* const pTemp = ppBinShuffle[iSwap];
-               --cRemaining;
-               ppBinShuffle[iSwap] = *ppBinShuffle;
-               *ppBinShuffle = pTemp;
                ++ppBinShuffle;
             } while(ppBinShuffleEnd != ppBinShuffle);
 

diff --git a/shared/libebm/tests/boosting_unusual_inputs.cpp b/shared/libebm/tests/boosting_unusual_inputs.cpp
@@ -2367,7 +2367,7 @@ static double RandomizedTesting(const AccelerationFlags acceleration) {
 }
 
 TEST_CASE("stress test, boosting") {
-   const double expected = 12286777380857.959;
+   const double expected = 12298977636064.098;
 
    double validationMetricExact = RandomizedTesting(AccelerationFlags_NONE);
    CHECK(validationMetricExact == expected);