fix: prevent update call in case of displaying recurring order active…

… status
intershop · Sep 4, 2024 · 027c4fd · 027c4fd
1 parent 76fcb27
commit 027c4fd
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 11 deletions.
diff --git a/src/app/pages/account-recurring-order/account-recurring-order-page.component.html b/src/app/pages/account-recurring-order/account-recurring-order-page.component.html
@@ -45,7 +45,7 @@ <h1>{{ 'account.recurring_order.heading' | translate }}</h1>
             ><ish-switch
               id="{{ recurringOrder.id }}"
               [active]="recurringOrder.active"
-              (switchActiveStatus)="switchActiveStatus($event)"
+              (switchActiveStatus)="switchActiveStatus($event, recurringOrder.active)"
           /></ng-template>
         </dd>
       </dl>

diff --git a/src/app/pages/account-recurring-order/account-recurring-order-page.component.ts b/src/app/pages/account-recurring-order/account-recurring-order-page.component.ts
@@ -18,7 +18,9 @@ export class AccountRecurringOrderPageComponent implements OnInit {
     this.recurringOrder$ = this.accountFacade.selectedRecurringOrder$;
   }
 
-  switchActiveStatus(recurringOrder: { id: string; active: boolean }) {
-    this.accountFacade.switchActiveStatusRecurringOrder(recurringOrder.id, recurringOrder.active);
+  switchActiveStatus(recurringOrder: { id: string; active: boolean }, switchStatus: boolean) {
+    if (recurringOrder.active !== switchStatus) {
+      this.accountFacade.switchActiveStatusRecurringOrder(recurringOrder.id, recurringOrder.active);
+    }
   }
 }
diff --git a/...p/pages/account-recurring-orders/recurring-order-list/recurring-order-list.component.html b/...p/pages/account-recurring-orders/recurring-order-list/recurring-order-list.component.html
@@ -106,8 +106,9 @@
           <ish-switch
             id="{{ recurringOrder.id }}"
             [active]="recurringOrder.active"
-            (switchActiveStatus)="switchActiveStatus($event)"
-        /></ng-template>
+            (switchActiveStatus)="switchActiveStatus($event, recurringOrder.active)"
+          />
+        </ng-template>
       </td>
     </ng-container>
 

diff --git a/...app/pages/account-recurring-orders/recurring-order-list/recurring-order-list.component.ts b/...app/pages/account-recurring-orders/recurring-order-list/recurring-order-list.component.ts
@@ -23,7 +23,9 @@ export class RecurringOrderListComponent {
 
   constructor(private accountFacade: AccountFacade) {}
 
-  switchActiveStatus(recurringOrder: { id: string; active: boolean }) {
-    this.accountFacade.switchActiveStatusRecurringOrder(recurringOrder.id, recurringOrder.active);
+  switchActiveStatus(recurringOrder: { id: string; active: boolean }, switchStatus: boolean) {
+    if (recurringOrder.active !== switchStatus) {
+      this.accountFacade.switchActiveStatusRecurringOrder(recurringOrder.id, recurringOrder.active);
+    }
   }
 }
diff --git a/src/app/shared/components/common/switch/switch.component.ts b/src/app/shared/components/common/switch/switch.component.ts
@@ -12,10 +12,10 @@ import { FormControl } from '@angular/forms';
  *
  * @example
  * <ish-switch
- *   id="{{ recurringOrder.id }}"
- *   [active]="recurringOrder.active"
- *   (switchActiveStatus)="switchActiveStatus($event)"
- * />
+ *    id="{{ recurringOrder.id }}"
+ *    [active]="recurringOrder.active"
+ *    (switchActiveStatus)="switchActiveStatus($event, recurringOrder.active)"
+ *  />
  */
 export class SwitchComponent {
   @Input({ required: true }) id: string;