Skip to content

Commit

Permalink
chore: update external documentation links and add check exceptions f…
Browse files Browse the repository at this point in the history
…or dead links
  • Loading branch information
SGrueber authored and shauke committed Dec 20, 2024
1 parent 5a1212d commit 1123b77
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 5 additions & 3 deletions docs/check-dead-links.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,16 @@ const filtered = externalLinks
.filter((val, idx, arr) => arr.indexOf(val) === idx)
.filter(
link =>
!link.includes('tacton.com') &&
!link.includes('repository.intershop.de') &&
!link.includes('support.intershop.') &&
!link.includes('docs.intershop.') &&
!link.includes('azurewebsites.net') &&
!link.includes('github.com') &&
!link.includes('github.com/intershop/intershop-pwa/commit') &&
!link.includes('ngrx.io') // service worker only
!link.includes('angular.io') &&
!link.includes('angular.love') &&
!link.includes('optimizesmart.com') &&
!link.includes('gnu.org') &&
!link.includes('tacton.com')
);

mapSeries(filtered, checkExternalLinkError).catch(error => {
Expand Down
4 changes: 2 additions & 2 deletions docs/guides/migrations.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,9 @@ The spelling of the OCI punchout actions has changed due to a changed naming sch

Since `defaultProject` is no longer a valid option in `angular.json`, it has been removed and the root project (project with an empty root) is used instead.

We enabled the [Angular Hydration](https://angular.io/guide/hydration) to improve performance and prevent the UI from flickering when a page renders - please note that this feature is still in developer preview and may have some limitations.
We enabled the [Angular Hydration](https://v16.angular.io/guide/hydration) to improve performance and prevent the UI from flickering when a page renders - please note that this feature is still in developer preview and may have some limitations.

From this version, we use the [`takeUntilDestroyed`](https://angularindepth.com/posts/1518/takeuntildestroy-in-angular-v16) operator to complete observables when the calling context (component, directive, service, etc) is destroyed.
From this version, we use the [`takeUntilDestroyed`](https://angular.love/takeuntildestroy-in-angular-v16) operator to complete observables when the calling context (component, directive, service, etc) is destroyed.
The `add-destroy` schematic has been removed but you can keep the `takeUntil(destroy$)` mechanism for a transitional period.
A [migration script](../../scripts/migrate-destroy-subject.ts) is created to support the migration to the new way to complete open observable subscriptions on destroy.
This script can be executed with `npx ts-node .\scripts\migrate-destroy-subject.ts`.
Expand Down

0 comments on commit 1123b77

Please sign in to comment.