Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: predefined endpoints for CMS REST product list component #1495

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

DiverDori
Copy link
Collaborator

@DiverDori DiverDori commented Aug 29, 2023

PR Type

[ ] Bugfix
[ x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

The REST Component can call any REST endpoint and has to be configured all seperately. If there several components, that call a certain sparque workspace, this has to be configered in each instance.

Issue Number: Closes #

What Is the New Behavior?

The sparque endpoint configuration of the PWA can be used to configure the REST component in ICM by using the "sparque://" notation, the same goes for "icm://" to use icm_base_url.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x ] No

Other Information

AB#89012

Eisie96 and others added 2 commits August 29, 2023 14:40
…preperation) (#1463)

* refactor ProductsService, SuggestService and FilterService to an abstract class and an ICM specific implementation
* prerequisite for using alternative Sparque services
…ice, documentation) (#1463)

* basic integration but no replaced services and REST requests (comes with additional commit)
@DiverDori DiverDori requested a review from shauke August 29, 2023 13:18
@DiverDori DiverDori self-assigned this Aug 29, 2023
@DiverDori DiverDori force-pushed the feature/predefined_endpoints_for_rest_component branch from a48523b to f6df09c Compare August 30, 2023 08:57
@DiverDori DiverDori force-pushed the feature/predefined_endpoints_for_rest_component branch from f6df09c to 9c77940 Compare August 30, 2023 09:20
@shauke shauke changed the title Feature/predefined endpoints for rest component feat: predefined endpoints for CMS REST product list component Sep 1, 2023
@shauke shauke assigned shauke and unassigned DiverDori Sep 1, 2023
@shauke shauke added this to the 5.0 milestone Sep 1, 2023
@shauke shauke modified the milestones: 5.0, 5.1 Dec 13, 2023
@shauke shauke removed this from the 5.1 milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants