refactor: enable eslint rule @ngrx/prefer-concat-latest-from #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
force-pushed
the
refactor/add_ngrx_eslint_rules
branch
from
b6a5e29 to
e44e320
Compare
Eisie96
approved these changes
Oct 30, 2023
| @@ -309,7 +309,7 @@ export class BasketEffects { | |||
| loadOrMergeBasketAfterLogin$ = createEffect(() => | |||
| this.actions$.pipe( | |||
| ofType(loginUserSuccess), | |||
| withLatestFrom(this.anonymousBasket$), | |||
| concatLatestFrom(() => this.anonymousBasket$), | |||
There was a problem hiding this comment.
The adavantage to use 'concatLatestFrom' to subscribe to the inner observable only when the source emits cannot be used here. 'anonymousBasket' is a effect which subscribes to its definition regardless of the wrapped operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Issue Number: Closes #
What Is the New Behavior?
Find more information here: https://ngrx.io/guide/eslint-plugin/rules/prefer-concat-latest-from
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#90176