Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable instant search #1614

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tbouliere-datasolution
Copy link
Contributor

PR Type

[ ] Bugfix
[x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

The search function is closely linked to the solr search service in the icm backend.

What Is the New Behavior?

A generic architecture for "instant search" is integrated into this project.
«Instant search» feature can be show there : www.ekosport.de (click on suche, then type «snow»).
You will see a layer that "fixes" the site and adds a drop-down panel, with results appearing "as you type".

The search provider is linked using an extension.

    //src/app/extensions/solr-instantsearch/exports/solr-instantsearch-exports.module.ts
    {
      provide: INSTANTSEARCH_COMPONENT_PROVIDER,
      useClass: SolrInstantSearchContentProvider,
      multi: true,
    },

An extension to return to the previous search behavior is included.

Legacy

This way, it is easier to integrate external search providers like sparque or algolia

Does this PR Introduce a Breaking Change?

[ x] Yes
[ ] No

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant