Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: load the main product image eagerly on PDP #1717

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Oct 11, 2024

  • because it is the LCP on this page

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[x] Other: Performance improvements

What Is the Current Behavior?

The main product image on PDP is lazily loaded. On mobile devices and also sometimes on desktop this image is the LCP of the product detail page and for performance reasons it should be loaded as fast as possible.

Issue Number: Closes #

What Is the New Behavior?

The main product image on PDP is loaded eagerly. Especially on mobile devices the LCP will decrease significantly.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#100535

* because it is the LCP on this page
@SGrueber SGrueber requested a review from shauke October 11, 2024 08:24
@SGrueber SGrueber self-assigned this Oct 11, 2024
@SGrueber SGrueber added the performance Performance improvements label Oct 11, 2024
@SGrueber SGrueber added this to the 5.3 milestone Oct 11, 2024
@shauke shauke merged commit 9326b29 into develop Dec 20, 2024
25 checks passed
@shauke shauke deleted the perf/product_image_loading branch December 20, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants