Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): expand search input on focus (#101784) #1726

Draft
wants to merge 4 commits into
base: feature/sparque_integration
Choose a base branch
from

Conversation

LucasHengelhaupt
Copy link
Contributor

@LucasHengelhaupt LucasHengelhaupt commented Dec 3, 2024

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

Issue Number: Closes #

What Is the New Behavior?

Does this PR Introduce a Breaking Change?

[ ] Yes
[ ] No

Other Information

added a 0.1s delay before playing the scale up animation to prevent weird flickering when

  1. the focus is inside the search input
  2. then the user clicks into another window that's not the PWA
  3. and then clicks back into the PWA but outside the search input

@LucasHengelhaupt LucasHengelhaupt self-assigned this Dec 3, 2024
@LucasHengelhaupt LucasHengelhaupt changed the base branch from develop to feature/sparque_integration December 3, 2024 16:16
@LucasHengelhaupt LucasHengelhaupt changed the title feat(search): expand search input on focus (non-sticky header) (#101784) feat(search): expand search input on focus (#101784) Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant