[uss_qualifier] add a default margin when querying interactions from mock_uss #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
interaction-logs-buffer
branch
from
b9af7ca to
e0ca9b8
Compare
…eractions from mock_uss
Shastick
force-pushed
the
interaction-logs-buffer
branch
from
e0ca9b8 to
d966bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances, even a slight clock skew can break qualifier scenarios that check for mock_uss interactions, depending on how tightly they set their time bounds.
This PR adds a default 5 seconds buffer to interaction queries made via the
mock_uss_interactionsutility method.Callers that need to disable this behavior may do so by passing
include_clock_skew_buffer = False.For an example of clock skew breaking scenarios, see here