Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the octomap dependency to the system version. #1314

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Switch the octomap dependency to the system version. #1314

merged 3 commits into from
Jul 23, 2024

Conversation

clalancette
Copy link
Contributor

We are shortly going to be removing octomap the package from ROS 2 Rolling; that's because it's ABI conflicts with the system package. Instead, switch rtabmap to use the system package, which should work fine.

See ros/rosdistro#41622 for more information.

Note that I targeted this at the rolling-devel branch, as that is what is listed in https://github.com/ros/rosdistro/blob/7a5a758b89acab0ce46632ca5ea6e9ba45d4c455/rolling/distribution.yaml#L6945-L6959 . Let me know if you'd prefer something else.

clalancette and others added 3 commits June 27, 2023 13:07
@clalancette
Remove dependency on qt_gui_cpp. (introlab#1072)
f8c4b62 
There is no dependency in this package on qt_gui_cpp.
Instead, just use a dependency on qtbase5-dev

Signed-off-by: Chris Lalancette <[email protected]>
@matlabbe
merged master->rolling
0f96178
@clalancette
Switch the octomap dependency to the system version.
ccca53b 
We are shortly going to be removing octomap the package
from ROS 2 Rolling; that's because it's ABI conflicts with
the system package.  Instead, switch rtabmap to use the system
package, which should work fine.

Signed-off-by: Chris Lalancette <[email protected]>
@matlabbe
Copy link
Member

could the same change be applied to Noetic, Humble, Iron and Jazzy? If so, I would change the target branch to master.

@clalancette
Copy link
Contributor Author

could the same change be applied to Noetic, Humble, Iron and Jazzy? If so, I would change the target branch to master.

I believe so; at least, the rosdep key seems to be available on all of Ubuntu Focal, Jammy, and Noble, along with RHEL-8 and RHEL-9. That constitutes all of the platforms that rosdep currently targets.

I'm happy for this to target master instead, so please feel free to make that change if you wish. That said, once this is merged I will be requesting an immediate release into Rolling, so please keep that in mind for whatever development process you use.

@matlabbe matlabbe changed the base branch from rolling-devel to master July 23, 2024 03:35
@matlabbe matlabbe merged commit 41dcddc into introlab:master Jul 23, 2024
5 checks passed
@matlabbe
Copy link
Member

matlabbe commented Jul 23, 2024 •
edited
Loading

Pull requests have been made on rosdistro.

I was worried that ros-noetic-octomap-msgs (used by rtabmap_ros) would depend on ros-noetic-octomap (to avoid cv_bridge VS system/ros opencv versions like issue) but it doesn't, even if there is a conversions.h file in octomap_msgs including octomap headers.

@clalancette
Copy link
Contributor Author

Pull requests have been made on rosdistro.

Thank you so much!

@clalancette clalancette deleted the clalancette/switch-octomap-dependency branch July 23, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @matlabbe