Issue:18 Lineage API depth -1 throws 500 error Instead of 400 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambekar15
suggested changes
Oct 21, 2020
| @@ -100,7 +100,7 @@ class LineageController @Inject()(cc: LineageControllerComponents) | |||
| // Produce a proper HTTP response for different success cases from LineageService | |||
| lineage.transform { | |||
| // A failure fetching lineage produces a 500 error code | |||
| case Failure(_) => Success(InternalServerError(s"""Unexpected error constructing lineage for table "$name"""")) | |||
There was a problem hiding this comment.
Negative depth is not supported. It is a validation error (bad request). With this change all server errors would return 404. We want to still return 500 for server errors . We should handle it in block of code where we are validating queryParams.
sambekar15
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
Lineage API depth -1 throws 500 error. Negative depth is not supported . Instead of throwing exception it should gracefully handle the error.
With this change, it will instead throw 404 Error instead of 500 with formatted JSON string as a response error message.
cc. @soojison @sambekar15