[Docs] week6 & week7 발표자료 업로드 [Feat] 스프링 시큐리티 & MemberService 테스트코드 작성 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Feat] 유효성 검사 & 예외처리 구현, [Docs] 4주차 발표자료 정리
82everywin
changed the title
82everywin
changed the title
Juser0
approved these changes
May 27, 2024
| protected void doFilterInternal(HttpServletRequest request, HttpServletResponse response, FilterChain filterChain) throws ServletException, IOException { | ||
| String authorizationHeader = request.getHeader(HttpHeaders.AUTHORIZATION); | ||
|
|
||
| // 토큰 전송 x -> 로그인 x |
| .authorizeHttpRequests((authorizeRequests) -> | ||
| authorizeRequests | ||
| .requestMatchers("/","/swagger-ui/**","/v3/api-docs/**").permitAll() | ||
| .requestMatchers("/api/members","api/members/login").permitAll() |
There was a problem hiding this comment.
requestMatchers에 인증없이 접근 가능한 uri들이 100개면 100줄의 permitAll을 담게 되는걸까?
| @EnableWebSecurity | ||
| public class SecurityConfig { | ||
|
|
||
| @Autowired |
| @@ -20,6 +25,13 @@ | |||
| public class MemberController { | |||
| private final MemberService memberService; | |||
|
|
|||
| @Value("${jwt.secret") | |||
| private String key; | |||
There was a problem hiding this comment.
해당 필드가 컨트롤러에 있는 이유가 뭐야?
tokenprovider에서 사용되는 요소 아녀?
|
|
||
| private final JwtTokenProvider jwtTokenProvider; | ||
|
|
||
| private CustomUserDetailService userDetailService; |
| @@ -91,13 +96,13 @@ public void delete(Long id){ | |||
| } | |||
|
|
|||
| // 회원 조회 메서드 | |||
| private Member throwFindbyId(Long id){ | |||
| public Member throwFindbyId(Long id){ | |||
There was a problem hiding this comment.
해당 메서드들의 접근제한자를 public으로 바꾼 이유가 뭐야?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 이슈 번호
close #62
close #63
🛠 구현 사항
week6 발표자료
service 계층 Member 테스트 코드 작성
week7 발표자료
스프링 시큐리티 및 로그인
📚 기타