feat: allows braces on citekey

[mapreal19]

No description provided.

[mapreal19]

@inukshuk this is what I attempted to fix #150 but is breaking other tests. This is the right direction?

[mapreal19]

Travis not running tests? Shall we move it to Github Actions?

[inukshuk]

I was thinking to only change the lexer pattern for the parser to accept braces; we shouldn't strip them off the key, because it would be unexpected for the parser to alter the contents (this would have to go into some kind of optional filter, e.g., normalize_keys or something like that, but I don't think that it's necessary)

Yes, I think we're still configured for travis-ci.org which has been suspended and moving to Github Actions would be desirable. I'll open an issue for it.

[mapreal19]

ok! I'll help with CI first

[mapreal19]

@inukshuk you can see the failing tests. Any idea of why including the braces in the regex pattern is breaking those tests?

[inukshuk]

Hm, for some reason adding the braces seems to make the key pattern match even beyond the final comma -- it's not obvious on a quick glance why that would happen. I'll have to take a closer look.

[mapreal19]

@inukshuk worth pursuing this issue?

[inukshuk]

Sure. Maybe it's just that the pattern is thrown off because the - is treated as a range delimiter because it's not at the end of the group anymore. Does it work if you escape the minus or move it back to immediately in front of the closing bracket?

[mapreal19]

I tried that but still one test that fails