Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interval refresher #699

Merged
merged 19 commits into from
Sep 30, 2024
Merged

Add interval refresher #699

merged 19 commits into from
Sep 30, 2024

Conversation

p6te
Copy link
Collaborator

@p6te p6te commented Jul 1, 2024

  • added interval refresher to the app.
  • handle refresh on timeout error
    image
    image
    image

wojciech-cichocki
wojciech-cichocki requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout problem:
image

wojciech-cichocki
wojciech-cichocki requested changes Jul 13, 2024
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a new target branch (sync with dev), and name it opt. We want to make the update atomic

wojciech-cichocki
wojciech-cichocki requested changes Jul 13, 2024
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refreshing blocks the entire app. What are the options to make it non-blocking?
Screencast from 13.07.2024 20:56:03.webm
video comment: (after triggering the refresh, I want to change the tick index. Actually the tick is updated the moment all the data is loaded (not all of this data is even needed to plot the chart)

@p6te p6te changed the base branch from dev to opt July 15, 2024 06:04
@p6te p6te changed the base branch from opt to dev September 20, 2024 13:35
wojciech-cichocki
wojciech-cichocki requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you remove loader from unclaimed fees?

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: ff2ec82
✅ Preview: https://webapp-91no519ua-invariantlabs.vercel.app
🔍 Inspect: https://vercel.com/invariantlabs/webapp/C9eBMLbX7FbcPwLMgB1PdSE1PuDs

View Workflow Logs

@p6te p6te merged commit 0268c3a into dev Sep 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zielvna zielvna zielvna approved these changes

@wojciech-cichocki wojciech-cichocki wojciech-cichocki approved these changes

Assignees
No one assigned
Labels
deployed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p6te @wojciech-cichocki @zielvna