add rpc warning #723
Merged
add rpc warning #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojciech-cichocki
requested changes
Sep 5, 2024
p6te
reviewed
Sep 5, 2024
and also for swap simulation, because it can not work, and user doesn't know why |
|
there is more error cases which are for Alchemy RPC, so errors can be different.
you can trigger handleError for errors: 400 and 429 too |
|
We can avoid crashing the app when user decided to use not recommended RPC. The case is when you choose any other RPC than Helius or Alchemy, write some number in the first input of swap, and then try to write something in the second input. Even if rpc is not working correctly we should avoid crashing the app. |
p6te
approved these changes
Sep 24, 2024
wojciech-cichocki
approved these changes
Sep 24, 2024
|
This pull request has been deployed to Vercel.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.