Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference: Add suggest API guide and custom index settings docs #687

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

sakshamarora1
Copy link
Contributor

Copy link
Member

@ptamarit ptamarit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to @jrcastro2 and I.
There are a few minor improvement suggestions.

docs/reference/search.md Outdated Show resolved Hide resolved
docs/reference/search.md Outdated Show resolved Hide resolved
docs/reference/search.md Outdated Show resolved Hide resolved
docs/reference/search.md Outdated Show resolved Hide resolved
docs/reference/search.md Show resolved Hide resolved
@ntarocco
Copy link
Contributor

I guess this is not for v12? More for v13?
If yes, then:

  • the target branch of this PR should be dev, and not master
  • please add the italic sub-header Introduced in InvenioRDM v13

@sakshamarora1 sakshamarora1 changed the base branch from master to dev August 20, 2024 08:39
Copy link
Contributor

@carlinmack carlinmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few fixes

docs/reference/search.md Outdated Show resolved Hide resolved
docs/reference/search.md Outdated Show resolved Hide resolved
docs/reference/search.md Outdated Show resolved Hide resolved
docs/reference/search.md Outdated Show resolved Hide resolved
docs/reference/search.md Outdated Show resolved Hide resolved
@carlinmack
Copy link
Contributor

The test is broken because there is a problem with https://github.com/inveniosoftware/docs-invenio-rdm/blob/dev/docs/releases/versions/version-v13.0.0.md which has been introduced on the dev branch with a link to the upgrade guide which doesn't exist

@ntarocco ntarocco merged commit 8537722 into inveniosoftware:dev Aug 27, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating documentation about analysers etc
4 participants