Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: use raw strings for regular expressions #101

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

max-moser
Copy link
Contributor

When installing some packages via uv and running scripts, sometimes warnings are printed about invalid escape sequences that point to the config in Flask-IIIF and Selenium (v3).
This PR replaces the normal strings with raw strings that do not interpret escape sequences (which is typically more convenient for regular expressions).

Copy link

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! (may have not even been working properly before)

},
"size": {
"ignore": "full",
"validate": (
"(^full|[\d.]+,|,[\d.]+|pct:[\d.]+|[\d.]+," "[\d.]+|![\d.]+,[\d.]+)"
r"(^full|[\d.]+,|,[\d.]+|pct:[\d.]+|[\d.]+,[\d.]+|![\d.]+,[\d.]+)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🏭

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK those are artifacts from the migration to black formatting 🐈‍⬛

@max-moser max-moser merged commit 28fef34 into inveniosoftware:master Sep 23, 2024
2 checks passed
@max-moser max-moser deleted the mm/raw-strings branch September 23, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants