forms: improve diversity of fields #154
Conversation
anikachurilova
force-pushed
the
improve-forms-and-date-formatter
branch
2 times, most recently
from
8a9289f
to
89fb4fe
Compare
invenio_administration/assets/semantic-ui/js/invenio_administration/src/formik/AdminForm.js
Show resolved
Hide resolved
..._administration/assets/semantic-ui/js/invenio_administration/src/components/DateFormatter.js
Show resolved
Hide resolved
invenio_administration/assets/semantic-ui/js/invenio_administration/src/formik/AdminForm.js
Outdated
Show resolved
Hide resolved
invenio_administration/assets/semantic-ui/js/invenio_administration/src/formik/AdminForm.js
Outdated
Show resolved
Hide resolved
invenio_administration/assets/semantic-ui/js/invenio_administration/src/formik/GenerateForm.js
Show resolved
Hide resolved
* display empty value if field is None * add possibility to prefill fields with default value * add possibility to specify the width of table column (search view) * add render of checkbox, dropdown and textarea fields * closes inveniosoftware/invenio-banners#10
anikachurilova
force-pushed
the
improve-forms-and-date-formatter
branch
from
89fb4fe
to
145d578
Compare
| {columns.map(([property, { text, order, width }], index) => { | ||
| if (!width) { | ||
| width = index === 0 ? undefined : index === 1 ? 4 : 3; | ||
| } |
There was a problem hiding this comment.
👍
Maybe in the future we need to find alternative methods to display the grid, as I had to do a custom back-end bound solution in the pages administration panel for it to look nice.
| options: formFieldConfig?.options || fieldSchema?.metadata?.options, | ||
| rows: formFieldConfig?.rows || fieldSchema?.metadata?.rows, |
There was a problem hiding this comment.
| options: formFieldConfig?.options || fieldSchema?.metadata?.options, | |
| rows: formFieldConfig?.rows || fieldSchema?.metadata?.rows, | |
| options: formFieldConfig?.options, | |
| rows: formFieldConfig?.rows, |
Minor: If I am not wrong the fieldSchema is a json representation of the marshmallow schema, this will never have options and rows attributes, unless I am missing something.
There was a problem hiding this comment.
You're totally right, marshmallow schema doesn't have rows and options, but it has metadata, to which we can
put anything we want. See here: https://github.com/inveniosoftware/invenio-banners/pull/15/files#diff-97da9b93fd82ecb3e421f77c8f0d82f16edeba13ed1b154cdc44572be3c37a3dR25
There was a problem hiding this comment.
Ah I see, was confused by the naming, we use metadata as well for the record's metadata, but I don't have better alternatives, thanks for clarifying!
| @@ -25,8 +25,11 @@ export const SearchResultsContainer = ({ | |||
| <Table> | |||
| <Table.Header> | |||
| <Table.Row> | |||
| {columns.map(([property, { text, order }], index) => { | |||
| const width = index === 0 ? undefined : index === 1 ? 4 : 3; | |||
| {columns.map(([property, { text, order, width }], index) => { | |||
Previews:
2.1 Render checkbox (Active) and dropdown (Category) fields.
2.2 Message field - text area
2.3 Prefill Start DateTime with default value (utcnow) and Active with True