Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependency on OAI-PMH, the menu should be inside the OAIPMH panel #205

Merged
merged 1 commit into from
May 15, 2024

Conversation

mesemus
Copy link
Contributor

@mesemus mesemus commented May 9, 2024

❤️ Thank you for your contribution!

Description

This pull request fixes issue #200 - invenio-administration uses url_for for OAI-PMH server but does not depend on it. The proposed solution is just to remove the explicit menu link for the new oaipmh set. A new set can be created from within the oai listing panel the same way other objects are created: https://github.com/inveniosoftware/invenio-rdm-records/blob/master/invenio_rdm_records/administration/views/oai.py

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Copy link
Contributor

@kpsherva kpsherva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for confirmation if the menu item is still visible in the app-rdm after this change

@kpsherva kpsherva merged commit 2e91d16 into inveniosoftware:main May 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants