Jobs registry #224
Merged
Jobs registry #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kpsherva
commented
Aug 23, 2024
kpsherva
commented
- closes jobs registry invenio-jobs#49
* add overridable action forms
kpsherva
force-pushed
the
jobs-registry
branch
from
5ac7f06
to
c93f4bb
Compare
kpsherva
commented
Aug 26, 2024
| function: null, | ||
| }; | ||
|
|
||
| export const mapFormFields = ( |
There was a problem hiding this comment.
it was moved from GenerateForm.js and refactored to improve readability. If anyone has an idea how to get rid of various if statements in the main function body, especially when trying to assign a correct type to a field, I would appreciate suggestions!
kpsherva
commented
Aug 26, 2024
| @@ -31,6 +31,7 @@ | |||
| data-resource-name='{{ resource_name | tojson }}' | |||
| data-pid-path='{{ pid_path | tojson }}' | |||
| data-request-headers='{{ request_headers | tojson }}' | |||
| data-name='{{ name }}' | |||
There was a problem hiding this comment.
will be used to override specific views with react-overridable.
* add overridable components to admin forms
kpsherva
force-pushed
the
jobs-registry
branch
from
c93f4bb
to
3fe06fa
Compare
(unknown fieldPath html attr)
kpsherva
force-pushed
the
jobs-registry
branch
from
eaf82d6
to
a5451fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.