service: raise when calling not implemented methods #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry didn't notice and opened #42 to mitigate this (which also doesn't need inveniosoftware/invenio-app-rdm#2742, but will "lie" about There's sort of a bigger refactor/lifting task that we could actually make, since we started seeing more and more use-cases of non-search-backed services, which I documented at inveniosoftware/invenio-records-resources#583. The class you have here, is definitely a good starting point to see how we make sure that we manage to enforce a good inheritance (or composition?) for downstream implementations. |
|
Closed in favor of #42 and a longer term solution later on for refactoring the DB-only service functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.