fix: before_app_first_request deprecation #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utnapischtim
force-pushed
the
add-init-function
branch
2 times, most recently
from
4edb24f
to
ea41c38
Compare
utnapischtim
force-pushed
the
add-init-function
branch
from
ea41c38
to
ca523ae
Compare
* the problem is that without existing tables the register_pages will fail. it is a edge case only in the beginning.
* The previous design of the module had some major usability issues:
* The assumption that we have views that are dynamically registered
without the need to redeploy/reload the application for code
changes is fundamentally flawed. In reality order for such views
to be accessible/discoverable, one has to be able to reference
them in Jinja templates, which in turn means one has to make code
changes.
* The way we were registering page views, required having a
connection to an already initialized database. This imposes having
to perform checks at application initialization that go against
well-established principles of the Flask/Invenio app lifecycle.
slint
force-pushed
the
add-init-function
branch
from
eca854d
to
bad9e5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.