Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js remove warnings #1835

Merged
merged 2 commits into from
Oct 3, 2024
Merged

js remove warnings #1835

merged 2 commits into from
Oct 3, 2024
+9 −5

Conversation

utnapischtim
Copy link
Contributor

  • fix: propTypes warning
  • fix: propTypes warning

@utnapischtim
fix: propTypes warning
2b18ff5 
* the recordRestrictionGracePeriod property is a number. the object
  which it is in the beginning in python (timedelta object) is reduced to
  the days in https://github.com/inveniosoftware/invenio-app-rdm/blob/master/invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/deposit.html#L45
@utnapischtim
fix: propTypes warning
22cd5ad 
* the canRestrictRecord property is optional in
  ProtectionButtonsComponent but required in ProtectionButtons.

* Since it is working without a problem, because of the default value in
  ProtectionButtonsComponent, the required has been removed from
  ProtectionButtons and replaced by a defaultProps definition to be
  consistent with the ProtectionButtonsComponent definition.
@kpsherva kpsherva merged commit 40d6999 into inveniosoftware:master Oct 3, 2024
4 checks passed
@utnapischtim utnapischtim deleted the js-remove-warnings branch October 3, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samk13 Samk13 Samk13 left review comments

@kpsherva kpsherva kpsherva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utnapischtim @Samk13 @kpsherva