-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce conditional DisableIf
generator & read-only mode
#86
base: master
Are you sure you want to change the base?
Introduce conditional DisableIf
generator & read-only mode
#86
Conversation
209f1a7
to
e0f95e2
Compare
DisableIf
generatorDisableIf
generator & read-only mode
e0f95e2
to
9da0188
Compare
45e082e
to
b250e67
Compare
Coordination: This one has been sitting for 3weeks+ Surfacing this back to attention for @utnapischtim , @ppanero and @ntarocco . If someone else would be better suited to look at it, let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It would be even better to add a test for a service:
RECORDS_PERMISSIONS_READ_ONLY = True
with PermissionDenied:
service.update(record, "owner", data)
@utnapischtim @ppanero please take a look! |
b250e67
to
3f9cc1a
Compare
* it seems like it was missing before
* this can be used to implement a conditional read-only mode, e.g. enabled temporarily to make system migrations smoother
3f9cc1a
to
a6c3afa
Compare
Given that Mr. E already provided the Given that we override most of the permission policies in our own modules anyway, we can add that feature in locally for us. |
This can be used to implement a conditional read-only mode, e.g. enabled temporarily to make system migrations smoother.
To do: