Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generators: add conditional generators #95

Conversation

rekt-hard
Copy link
Contributor

❤️ Thank you for your contribution!

Description

closes inveniosoftware/invenio-rdm-records#1226

Add general conditional generators for re-usability.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@ntarocco ntarocco force-pushed the generic-conditional-permission-generators branch from e1b310a to 82a6ba2 Compare August 14, 2023 15:23
@ntarocco ntarocco merged commit 355db4b into inveniosoftware:master Aug 14, 2023
6 checks passed
@ppanero
Copy link
Member

ppanero commented Aug 14, 2023

Should we add tests since this is touching permissions 😇

@ntarocco
Copy link
Contributor

We should indeed 👼🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move some generic permission generators to records-pemissions
3 participants