New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facets: convert number to locale, a11y improvements #184

Merged

zzacharo merged 1 commit into inveniosoftware:master from jennur:facets

Sep 12, 2023

Member

jennur commented Sep 12, 2023 •

edited

Loading

Closes #182, closes inveniosoftware/invenio-app-rdm#2256, closes #181

Converts all result-numbers to locale
Sets the aria-label to the responsive sidebar (needs responsive sidebar: add aria-label prop and aside wrapper elem react-invenio-forms#208)
Modifies the elements within the sidebar according to the PR mentioned above
Improves screen reader navigation by adding section to the search results wrapper element
Better a11y for count-labels

Screenshot 2023-09-12 at 14 36 55

Screenshot 2023-09-12 at 16 46 37

jennur force-pushed the facets branch from 7f0d77f to a5dd421 Compare

September 12, 2023 14:48


          facets: convert number to locale, a11y improvements

zzacharo force-pushed the facets branch from a5dd421 to 9726686 Compare

September 12, 2023 19:30

zzacharo merged commit 15b8a8e into inveniosoftware:master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet