Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons: removed option role #192

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

0einstein0
Copy link
Member

❤️ Thank you for your contribution!

Description

Removed option role form icons

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@@ -62,7 +62,7 @@ export class DropdownSort extends Component {
trigger={
<span className="flex align-items-center">
{this.getCurrentlySelectedOption(parsedOptions).text}
<Icon name="dropdown" role="option" />
<Icon name="dropdown" />
Copy link
Contributor

@kpsherva kpsherva Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the role be set on the Dropdown instead (or it's elements/options )?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Icon was inside a parent element with role listbox so it required the child elements to have the role option, which wouldn't work with icon, I added it but with screen reader it won't make sense, so removed it later

@kpsherva kpsherva merged commit 6969c79 into inveniosoftware:master Sep 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants