Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add MathJax support #394

Merged
merged 1 commit into from
Sep 17, 2024
Merged

config: add MathJax support #394

merged 1 commit into from
Sep 17, 2024

Conversation

anikachurilova
Copy link
Contributor

ntarocco
ntarocco reviewed Sep 9, 2024
View reviewed changes
invenio_theme/templates/semantic-ui/invenio_theme/page.html
@@ -115,6 +115,19 @@
{%- endblock body_inner %}

{%- block javascript %}

{% if config.THEME_MATHJAX_CDN %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not adding this to the file javascript.html instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is because if we override javascript.html we need to remember to recreate it in the overridden file

@kpsherva kpsherva merged commit d32d934 into inveniosoftware:master Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpsherva kpsherva kpsherva left review comments

@ntarocco ntarocco ntarocco left review comments

@jrcastro2 jrcastro2 jrcastro2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LaTeX rendering
4 participants
@anikachurilova @ntarocco @jrcastro2 @kpsherva