Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates: page_cover: Add banner to login template #395

Merged
merged 2 commits into from
Oct 30, 2024
Merged

templates: page_cover: Add banner to login template #395

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddf7a8f
templates: page_cover: Add banner to login template
sakshamarora1 Sep 2, 2024
aa03db8
templates: page_cover: Add site_banner empty block
sakshamarora1 Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions invenio_theme/templates/semantic-ui/invenio_theme/page_cover.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@

{%- block body %}
<div class="sixteen wide column centered">
{%- block site_banner %}
{% from 'invenio_banners/banner.html' import banner %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a direct dependency on invenio-banners in this module...I think it is better to either keep the block here and implement the banner in a "higher" level module or completely move this to another module where it depends on invenio-banners.

{{ banner() }}
{%- endblock site_banner %}

{%- block flashmessages %}
{%- from "invenio_theme/macros/messages.html" import flashed_messages with context -%}
{{ flashed_messages(center_text=true) }}
Expand Down
Loading