Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: get domain via id #149

Closed
wants to merge 1 commit into from

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented Nov 6, 2024

❤️ Thank you for your contribution!

(Part of) Close inveniosoftware/invenio-app-rdm#2777

Description

Please describe briefly your pull request.

Relies on inveniosoftware/invenio-accounts#500

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

with db.session.no_autoflush:
domain = current_datastore.find_domain(id_)
domain = current_datastore.find_domain_by_id(id_)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
domain = current_datastore.find_domain_by_id(id_)
domain = current_datastore.find_domain(id_)

minor: see inveniosoftware/invenio-accounts#500 (comment), which would mean no need to change anything here.

@carlinmack carlinmack closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domains: Existing Domains Not Visible on Admin Page After Login
2 participants