-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom states #4969
Custom states #4969
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
@SchrodingersGat I'm sorry to see this PR moved into horizon. I use the stock status a lot. There is nothing wrong with the default tags. However I also flag other reasons such as As a compromize I modify the core code for each upgrade so the tags and business logic reflects the most important conditions I use and thus sacrifice the default tags. Works well for me, but obvioulsy have some drawbacks that would be resolved if customized Stock Status were implemented. We discussed the same also in #4289 and I then said I will give it a try to develop but have realized that the complexity to implement is far beyond my coding skills. When I see what @matmair has done already in this PR that becomes even more clear. I so greatful for all your work on InvenTree and realize you have tons of requests and need to prioritize. But I just want to highligt that for me this would be a really nice feature. |
@matmair I'm interested on what the current status of this PR is, it seems like it has no file changes? Did you started implementing this already and have some unpublished code? And do you plan to continue this in some time? |
I have a POC that was developed in tandem with #4857, most of the generalised stuff was merged into #4857 eventually and the rest is already used (with a few ineficientes / edge cases TBH) in my deployed instances. That is a huge change in the possible depth of (busniess) logic-change plugins can make. So I wanted to wait for #5861, #5578, #2493 to ensure we are not stuck with either a lot of questions about the different models or broken plugins that messed up users instances. That is an organisational thing, not a technical blocker. This PR could certainly be finished without adressing these project-level short-comings. |
Ok, thanks for the detailed explanation. But unfortunately I have no time developing this. I really appreciate your work. |
At some point, I want to tackle this but it is low on the ToDo. I will close this PR, it suggests that I am active on this front, which I am not. |
Continuation of #4857. This PR will add database interactions for states - enabling custom states.