Approval

[matmair]

Follow up to #5095

Simplified implementation of approvals for orders. Includes building blocks for a more generalized rules and template-driven approach.

Function

This PR adds approvals (optionally) for POs. You can enable them in settings (including minimum approvers and maximum rejections). After that POs can only be placed once they are approved.

Notifications

Notifications will be sent out to the responsible user/group:

• when approval starts
• on each approval decision
• after being rejected (PO will be cancelled)
• after being approved (PO will be moved to placed)

UI

As an experiment, I just implemented this in P UI. While the order views are not ready in P UI, approvals are.

Next steps

This is an MVP, I opened an epic for further improvements #5097.
While this PR adds a business logic and UI for PO approvals, approvals are a first-class citizen implementation-wise. They can be used as-is for any model and adding UI elements for that should be simple. The default rules engine is also simple right now but designed for complex requirements. If there is interest this can be extended.

Still to address

Beta Give feedback

1. Add a general approval flow (creation/viewing/approval/declining)
2. Make orders a bit more helpful
3. Jump-of-point to the general approval thing in C UI
4. Migrate PO stuff into its own PR
5. Add auto-generation of approval names
6. Add UI for choosing name for approval
7. Add docs
8. Add info-bubble with link to epic for feedback

Closes #3501

[netlify]

✅ Deploy Preview for inventree ready!

Name	Link
🔨 Latest commit	58da88c
🔍 Latest deploy log	https://app.netlify.com/sites/inventree/deploys/650f144eacad0400080b6578
😎 Deploy Preview	https://deploy-preview-5559--inventree.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 100 Accessibility: 86 Best Practices: 100 SEO: 70 PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[SchrodingersGat]

@matmair I was under the impression that we were pretty good to go on this one - just waiting on #5597 which was only just merged.

Are you happy for me to re-open and have a proper review? It has only been through lack of time that I have not done this yet

[matmair]

I did not close this because of no review from your side, #5597 was just a way to kill some time till feedback rolls in. There is no intrest any more from the people that requested the feature originally.

I will move this to a plugin that allows me to be more agile and code specific to my use cases.

[imsoumyaprakash]

Hi,

Just pitching in here to bring to notice, I am very much interested in this feature coming to picture.
In case additional support is needed, I can pitch in to build the features as well.

[matmair]

Thanks for the interest @imsoumyaprakash. I have already lost interest in pursuing this in the public and started work polishing and moving the code into a closed plugin. You are more than welcome to use the ideas in this PR, but I won't focus on bringing this into core anymore.