-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configurable ldap group classes #8475
configurable ldap group classes #8475
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
This should also address: #8365 (reply in thread) |
d79b997
to
43b5f45
Compare
43b5f45
to
cdf67f3
Compare
Force pushed to amend commit author which was incorrect, my apologies |
I do not have a non-prod setup with LDAPS right now, I would have to build something up in my lab so if Lukas has something I would let him test it. |
For reference, these are the new setting values I used to make this work in my environment INVENTREE_LDAP_GROUP_OBJECT_CLASS: group
INVENTREE_LDAP_GROUP_TYPE_CLASS: NestedMemberDNGroupType
INVENTREE_LDAP_GROUP_TYPE_CLASS_ARGS: member
INVENTREE_LDAP_GROUP_TYPE_CLASS_KWARGS: '{"name_attr": "cn"}' |
Sorry, I have currently also no testing setup and very limited time, so this will take me some time to get to it. I'd appreciate if someone of you could test this. |
@jacobfelknor can you confirm that the new settings are working for your setup? |
Yes, I'm currently using these settings in my instance and it works with my environment |
Ok, can you please fix the style issues and I'm happy to merge. If there are any issues which arise you may get tagged :) |
Okay, I think that should fix the styling |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8475 +/- ##
==========================================
- Coverage 84.35% 84.34% -0.01%
==========================================
Files 1178 1178
Lines 53746 53751 +5
Branches 2029 2029
==========================================
Hits 45337 45337
- Misses 7896 7901 +5
Partials 513 513
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jacobfelknor thanks for the contribution :) |
Addresses #6101
Allow more granular LDAP group configuration. If no action is taken, this behaves as it did before due to defaults.