Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "installed in" display #8480

Merged
merged 11 commits into from
Nov 15, 2024

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Nov 13, 2024

Tasks

  • Allow "details" field to be passed custom params
  • Add playwright testing for "installed in" (item 176)
  • Display tracking info for "installed into assembly" (see "stock tracking" tab)
  • Add playwright testing for above

- Allow "details" field to be passed custom params
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed user interface User interface Platform UI Related to the React based User Interface labels Nov 13, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 13, 2024
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 980de39
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/673737cd37140b00089ec752
😎 Deploy Preview https://deploy-preview-8480--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.94%. Comparing base (b5599c9) to head (980de39).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...c/frontend/src/tables/stock/StockTrackingTable.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8480      +/-   ##
==========================================
- Coverage   84.39%   83.94%   -0.45%     
==========================================
  Files        1178     1178              
  Lines       53744    54117     +373     
  Branches     2027     2029       +2     
==========================================
+ Hits        45356    45430      +74     
- Misses       7862     8176     +314     
+ Partials      526      511      -15     
Flag Coverage Δ
backend 85.91% <100.00%> (ø)
pui 68.35% <66.66%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit fbe222f into inventree:master Nov 15, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the installed-in-fix branch November 15, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant