Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): required compatibility for android gradle plugin 8 #7412

Merged
merged 5 commits into from
Oct 21, 2023

Conversation

mikehardy
Copy link
Collaborator

Description

A collection of android gradle plugin 8 compatibility fixes

  • Fixes all the remaining instances where react-native-firebase modules weren't compatible yet (we were mostly there, thankfully)
  • Sends a PR upstream for detox fix(android): add namespace to build.gradle for android gradle plugin 8 compatibility wix/Detox#4229 - although we're currently stuck on an old version, they'll need this I think, and our local patch is updated for AGP8
  • adopts just released version of invertase/jet where I patched+released it for AGP8
  • updates the test app here to use AGP8 to show the whole thing works...

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

With gratitude to @AndreiCalazans for starting this process of gradle 8
compatibility, there were a few modules that still needed updates to
handle the new default-off BuildConfig setting breaking change from gradle 8

This is required for react-native 0.73 compatibility (currently in RC phase)
as they adopt gradle 8 there
proves the whole thing works now via dog-fooding...
…espace location

in AGP8+ compatible projects the package name will be in android/app/build.gradle,
not in the old location in AndroidManifest.xml
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Oct 20, 2023
@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 11:44pm
react-native-firebase-next ❌ Failed (Inspect) Oct 20, 2023 11:44pm

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #7412 (ec727a7) into main (2d8ac14) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7412      +/-   ##
============================================
- Coverage     54.12%   54.11%   -0.00%     
  Complexity      738      738              
============================================
  Files           248      248              
  Lines         12163    12163              
  Branches       1897     1897              
============================================
- Hits           6582     6581       -1     
- Misses         5235     5236       +1     
  Partials        346      346              

@mikehardy mikehardy merged commit 04ed440 into main Oct 21, 2023
14 of 15 checks passed
@mikehardy mikehardy deleted the @mikehardy/agp-8-cleanup branch October 21, 2023 01:05
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant