-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): required compatibility for android gradle plugin 8 #7412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With gratitude to @AndreiCalazans for starting this process of gradle 8 compatibility, there were a few modules that still needed updates to handle the new default-off BuildConfig setting breaking change from gradle 8 This is required for react-native 0.73 compatibility (currently in RC phase) as they adopt gradle 8 there
(or patch them...)
proves the whole thing works now via dog-fooding...
…espace location in AGP8+ compatible projects the package name will be in android/app/build.gradle, not in the old location in AndroidManifest.xml
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8 tasks
mikehardy
force-pushed
the
@mikehardy/agp-8-cleanup
branch
from
October 20, 2023 21:47
c42f766
to
0eb1939
Compare
mikehardy
force-pushed
the
@mikehardy/agp-8-cleanup
branch
from
October 20, 2023 23:39
0eb1939
to
ec727a7
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7412 +/- ##
============================================
- Coverage 54.12% 54.11% -0.00%
Complexity 738 738
============================================
Files 248 248
Lines 12163 12163
Branches 1897 1897
============================================
- Hits 6582 6581 -1
- Misses 5235 5236 +1
Partials 346 346 |
10 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A collection of android gradle plugin 8 compatibility fixes
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter