-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app-check): Replay Protection #7424
feat(app-check): Replay Protection #7424
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I think there should be entries in the index.d.ts files so that they are available in typescript?
Also, I think it should be possible to add an entry for this in the e2e test suite for app-check, that way we can see in CI that the methods really are working + not crashing (also, they will help you determine locally that they are working before pushing to the PR branch - best practice is to add an e2e test and put .only
on it so when you run the suite locally it is super fast to run it + iterate on code changes
Thanks! I remember I couldn't get the project installed locally last time I tried, so I had to skip the tests. Will try and look at this again soon |
this was a vestige of original implementation plan for the iOS custom app check provider, unused in the end
When I took this one and attempted to add tests to it, it hung on iOS - need to investigate why but I suspect it has something to do with not being able to proxy to the currently configured provider from our custom provider, and calling the API directly on the FIRAppCheck. It appears this new API isn't implemented on the Provider interfaces unlike getToken, for some reason, and I've got an API shape question out upstream to see if I can understand it better firebase/firebase-ios-sdk#11284 (comment) |
worked through my iOS question with more investigation, made iOS implementation proxy to current delegate should be good to go assuming CI goes ✅ |
8381e85
to
21e872d
Compare
Thank you so much!! |
I pushed those changes at the same time github suffered an outage. Just closing / reopening to kick off the CI jobs that should have run |
Description
This PR adds the Replay Protection feature for App Check, where it provides a consumable token for single-use server calls.
Related issues
#7394
Release Summary
getLimitedUseToken
Provides single-use tokens for enhanced security on the server.Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Tested in a private repo with the emulator.