Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(expo): improve links and instructions for expo managed workflow #7437

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

gregfenton
Copy link
Contributor

@gregfenton gregfenton commented Nov 5, 2023

The links and descriptions of how to create a new Expo app and how to install RNF were incorrect.

These updates push more responsibility to the Expo docs themselves and reduce the amount that RNF needs to document.

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

The links and descriptions of how to create a new Expo app and how to install RNF were incorrect.

These updates push more responsibility to the Expo docs themselves and reduce the amount that RNF needs to document.
Copy link

vercel bot commented Nov 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 6:04pm
react-native-firebase-next 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 6:04pm

mikehardy
mikehardy previously approved these changes Nov 6, 2023
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great to me - thank you!
CI seems to have something to say about markdown and spelling pretty frequently with docs changes but I can shepherd those through to merge pretty quickly while working on the repo today

@mikehardy mikehardy changed the title [doc] FIX: Expo Managed Workflow links and descriptions docs(expo): improve links and instructions for expo managed workflow Nov 6, 2023
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Nov 6, 2023
@mikehardy mikehardy merged commit 39d4ba4 into invertase:main Nov 6, 2023
8 of 9 checks passed
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants