Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url not display username #36

Merged
merged 1 commit into from
Feb 19, 2024
Merged

fix: url not display username #36

merged 1 commit into from
Feb 19, 2024

Conversation

Kimthean
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
khmercoders ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 5:09pm

@rin-yato rin-yato changed the title fix url not display name fix: url not display name Feb 19, 2024
@rin-yato rin-yato changed the title fix: url not display name fix: url not display username Feb 19, 2024
Copy link
Collaborator

@rin-yato rin-yato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rin-yato rin-yato merged commit 0e96211 into main Feb 19, 2024
3 checks passed
avevotsira pushed a commit that referenced this pull request Feb 21, 2024
invisal added a commit that referenced this pull request Feb 25, 2024
* feat: user profile page

* fix : db loader issue ,moved load more to client side

* refactor : change the profile page to use ArticlePreview

* fix : fixing the load more logic

* fix : fix the user-profile-button

* ci: add prettier-plugin-tailwindcss (#29)

* ci: add prettier-plugin-tailwindcss

* chore: run format:write

* fix url not display name (#36)

* feat: add support for slug (#33)

* feat: add slugify

* feat: update schema and migration

* feat: add slug in the api

* feat: update article page to get id from slug

* fix: store slug independently

* fix : prettier lint

* style: add a wrapper to Articles , remove shadow from user profile

* refactor : changes query articles by username to userId

* refactor: getArticlesByUserId.then(ok) instead

* remove unused parts

---------

Co-authored-by: RinYato <[email protected]>
Co-authored-by: Kimthean <[email protected]>
Co-authored-by: Visal .In <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants