Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: login with github #52

Merged
merged 1 commit into from
Mar 1, 2024
Merged

feat: login with github #52

merged 1 commit into from
Mar 1, 2024

Conversation

avevotsira
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
khmercoders ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 3:19am

Copy link
Collaborator

@Kimthean Kimthean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can wait for yato review too

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -22,6 +22,10 @@ const Page = async () => {
<Input type="password" name="password" id="password" />
<br />
</AuthForm>
<a href="api/oauth2/github" className="buttonClass">
Sign in with GitHub
</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any styling on this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not right now , do we have a plan to redo the sign up page or something , cause i might just do it whole there or something?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe redo the sign up page is not in this PR scope.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright

@invisal invisal merged commit b8b876c into main Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat : Implement Oauth2
4 participants