Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MedVis: DICOM sanity check fix #239

Merged
merged 4 commits into from
Nov 29, 2024
Merged

MedVis: DICOM sanity check fix #239

merged 4 commits into from
Nov 29, 2024

Conversation

martinfalk
Copy link
Contributor

No description provided.

Copy link

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v17.0.6) reports: 4 concern(s)
  • medvis/dicom/include/inviwo/dicom/datastructures/dicomdirtypes.h:31:10: error: [clang-diagnostic-error]

    'inviwo/dicom/dicommoduledefine.h' file not found

       31 | #include <inviwo/dicom/dicommoduledefine.h>
          |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  • medvis/dicom/src/datastructures/dicomdirtypes.cpp:30:10: error: [clang-diagnostic-error]

    'inviwo/dicom/datastructures/dicomdirtypes.h' file not found

       30 | #include <inviwo/dicom/datastructures/dicomdirtypes.h>
          |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  • medvis/dicom/src/io/gdcmvolumereader.cpp:30:10: error: [clang-diagnostic-error]

    'inviwo/dicom/io/gdcmvolumereader.h' file not found

       30 | #include <inviwo/dicom/io/gdcmvolumereader.h>
          |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  • tensorvis/tensorvisio/src/processors/tensorfield2dimport.cpp:30:10: error: [clang-diagnostic-error]

    'inviwo/tensorvisio/processors/tensorfield2dimport.h' file not found

       30 | #include <inviwo/tensorvisio/processors/tensorfield2dimport.h>
          |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Have any feedback or feature suggestions? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v17.0.6

No concerns from clang-tidy.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.

@petersteneteg petersteneteg merged commit efc6c99 into master Nov 29, 2024
13 of 14 checks passed
@petersteneteg petersteneteg deleted the feature/dicom-fix branch November 29, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants