Implement Command Line Options #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3nu
reviewed
Jul 11, 2018
setup.py
Outdated
| setup( | ||
| name='factur-x', | ||
| version=verstr, | ||
| author='Alexis de Lattre', | ||
| author_email='[email protected]', | ||
| url='https://github.com/akretion/factur-x', | ||
| description='Factur-X: electronic invoicing standard for Germany & France', | ||
| long_description=open('README.md').read(), | ||
| long_description=open('README.rst').read(), | ||
| package_data = { |
There was a problem hiding this comment.
Please look into adding a Manifest file. It allows to integrate subfolders more easily.
|
Done |
|
CLI code needs to be separate. Can't be with the main class/library. |
|
Like this or outside facturx package all together? |
|
Separate file in the same package. See how other projects split it up. It's not commonly thrown together with the actual library. Except for very small tasks. In |
|
Done. I have moved it to |
|
ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two options have been implemented
dumpandvalidateNeed to add one more #13
For issue #3