Skip to content

Commit

Permalink
extend dependency blacklist
Browse files Browse the repository at this point in the history
  • Loading branch information
mcm1957 committed Oct 26, 2024
1 parent 72d32a7 commit 5da6af9
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 5 deletions.
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ Branch (`master/main/dev`) is optional.
-->

## Changelog
### **WORK IN PROGRESS**
* (mcm1957) linter has been activated and issues reported have been fixed.
* (mcm1957) Blacklist for package/dependencies has been extended.
* (mcm1957) Recommend adapter-core 3.2.2 now.

### 3.1.3 (2024-10-11)
* (mcm1957) Checker no longer crash id no npm package exists.

Expand Down
43 changes: 38 additions & 5 deletions lib/M000_PackageJson.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,16 @@ const compareVersions = require('compare-versions');

const common = require('./common.js');

const recommendedNodeVersion = '18'; // This is the minimum node version that should be required
const requiredNodeVersion = '18'; // This is the minimum node version that must be required
// Note: node version specify rules for engines clase and do NOT reflect the recommended node version for users
const recommendedNodeVersion = '18'; // This is the minimum node version that should be required at engines clause
const requiredNodeVersion = '18'; // This is the minimum node version that must be required at engines clause

/* TODO: configuration should be moved to context */

const dependenciesPackageJson = {
'@iobroker/adapter-core': {
required: '3.1.4',
recommended: '3.1.6',
recommended: '3.2.2',
},
};

Expand All @@ -33,11 +34,15 @@ const devDependenciesPackageJson = {

const blacklistedDependenciesPackageJson = {
'npm': {
msg: "'npm'must not be listed as dependency at package.json. Please remove.",
msg: "'npm'must not be listed as dependency at package.json. Please remove and create new release.",
err: true
},
'iobroker.js-controller': {
msg: "'iobroker.js-controller' must not be listed as dependency at package.json. Please remove.",
msg: "'iobroker.js-controller' must not be listed as dependency at package.json.Please remove and create new release.",
err: true
},
'@iobroker/adapter-dev': {
msg: "'@iobroker/adapter-dev' must not be listed as dependency at package.json. Please remove and create new release.",
err: true
},
'@iobroker/dev-server': {
Expand All @@ -48,6 +53,34 @@ const blacklistedDependenciesPackageJson = {
msg: "'@iobroker/plugin-sentry' must not be listed as dependency at package.json as it will crash js-controller 7 systems. Please remove and create new release.",
err: true
},
'@iobroker/repochecker': {
msg: "'@iobroker/repochecker' must not be listed as dependency at package.json. Please remove and create new release.",
err: true
},
'@alcalzone/release-script': {
msg: "'@alcalzone/release-script' must not be listed as dependency at package.json. Please remove and create new release.",
err: true
},
'@alcalzone/release-script-plugin-iobroker': {
msg: "'@alcalzone/release-script-plugin-iobroker' must not be listed as dependency at package.json. Please remove and create new release.",
err: true
},
'@alcalzone/release-script-plugin-license': {
msg: "'@alcalzone/release-script-plugin-license' must not be listed as dependency at package.json. Please remove and create new release.",
err: true
},
'@alcalzone/release-script-plugin-package': {
msg: "'@alcalzone/release-script-plugin-package' must not be listed as dependency at package.json. Please remove and create new release.",
err: true
},
'@alcalzone/release-script-plugin-manual-review': {
msg: "'@alcalzone/release-script-plugin-manual-review' must not be listed as dependency at package.json. Please remove and create new release.",
err: true
},
'@alcalzone/release-script-plugin-version': {
msg: "'@alcalzone/release-script-plugin-version' must not be listed as dependency at package.json. Please remove and create new release.",
err: true
},
};

const blacklistedDevDependenciesPackageJson = {
Expand Down

0 comments on commit 5da6af9

Please sign in to comment.