Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamlining the log and debug output #332

Closed
wants to merge 1 commit into from

Conversation

oweitman
Copy link
Contributor

No description provided.

} else if (baseType == 'tabs') {
checkTabs( context, `${path}/items`, jsonConfig['items'], false);
checkTabs(context, `${path}/items`, jsonConfig['items'], false);

Check warning

Code scanning / CodeQL

Superfluous trailing arguments Warning

Superfluous argument passed to
function checkTabs
.
@mcm1957
Copy link
Collaborator

mcm1957 commented Nov 12, 2024

I do not see any benefit to route console.log into common only to rename console.log to common.log.
And I prefer to keep routine executions to be logged at all runs and not to convert it to debug logs. This makes progress more visible at workflow runs.

@mcm1957 mcm1957 closed this Nov 12, 2024
@oweitman
Copy link
Contributor Author

oweitman commented Nov 12, 2024

This was mainly intended to ensure that all output commands for console.debug, console.log and console.error are in one corner and that there is no mixed use of console.log and common.debug.

Other changes were mainly to declare all output that does not primarily describe progress as debug output and to reduce the number of newlines.

the new output without --debug now looks like this

`
[INFO] running in LOCAL mode
Checking repository https://github.com/oweitman/ioBroker.squeezeboxrpc (branch main)
[E001 - E099] checkPackageJson
[E100 - E249] checkIOPackage
[E250 - E299] checkNpm
[E400 - E499] checkRepository
[E5xx] checkCode
[E300 - E399] checkTests
[E8xx] checkGithubRepo
[E600 - E699] checkReadme
[E7xx] checkLicenseFile
[E95x] checkNpmIgnore
[E9xx] checkGitIgnore

########## SUMMARY ##########
NO errors encountered.
Warnings:
[W252] Version of package.json (1.4.0-alpha.2) doesn't match latest version on NPM (1.3.17)
[W606] Could not retrieve timestamp of LATEST revision at npm.

created by repochecker 3.2.2 based on commit 60e191a293ba988aba35e641f7529a3daea68a9e

`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants