Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lifx to 1.0.3 at stable #2735

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Update lifx to 1.0.3 at stable #2735

merged 1 commit into from
Oct 12, 2023

Conversation

foxthefox
Copy link
Contributor

update lifx 1.0.3

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Oct 9, 2023
@mcm1957 mcm1957 changed the title Update sources-dist-stable.json Update lifx to 1.0.3 at stable Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Automated adapter checker

ioBroker.lifx

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

  • ❗ [E518] "@alcalzone/release-script" is used, but ".releaseconfig.json" not found
  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 9, 2023

@foxthefox
Your adapter https://github.com/foxthefox/ioBroker.lifx does not use standard iobroker testing using node 16/18/20

Please see requirements https://github.com/ioBroker/ioBroker.repositories#requirements-for-adapter-to-get-added-to-the-latest-repository which is also required for stable repository.

Adapter needs to have at least Adapter basic testing (installing, running) using GitHub actions. More information in forum from apollon77 (Just take from other adapters the samples)

Currently your testmatrix only contains node 18. Iobroker officially supports node 16 / 18 / 20. Tests should be run for every node version supported. So please add node 16 and node 20 to your test matrix and retrigger a test.

If you do not or cannot support node 16, it's ok the add an 'engine: >=18' clause to package.json so that node 18 or newer ist required during installation.

If you know that you adapter fails with node 20 temporary omit node 20 tests but add an issue describing the problem and try to fix it as soon as possible.

Please feel free if you need any help setting up standard testing and / or if you prefer a that we / I create a PR to fix this.

Please add a comment when you have reviewed and fixed the suggestion or at least commented the suggestions and you think the adapter is ready for a re-review

@mcm1957 mcm1957 added the ON HOLD PR is set ON HOLD due to pending question or major issues. label Oct 9, 2023
@foxthefox
Copy link
Contributor Author

testing is now with 16,18,20

@mcm1957 mcm1957 added (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. labels Oct 12, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 12, 2023

1.0.3 created 24.09.2023
OK

@mcm1957 mcm1957 merged commit 62aea30 into ioBroker:master Oct 12, 2023
16 checks passed
@mcm1957 mcm1957 removed the (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants