Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update viessmann to 1.4.9 #4142

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Update viessmann to 1.4.9 #4142

merged 1 commit into from
Oct 9, 2024

Conversation

misanorot
Copy link
Contributor

No description provided.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias labels Oct 7, 2024
@mcm1957 mcm1957 changed the title Update viessmann Update viessmann to 1.4.9 Oct 7, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 7, 2024

@misanorot

Tests for nodeJS 22 are missing. Please add

See misanorot/ioBroker.viessmann#232
and misanorot/ioBroker.viessmann#223

A new release is not required but tests must be actoivated and shoul pass

reminder 14.10.2024

@mcm1957 mcm1957 added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. labels Oct 7, 2024
Copy link

github-actions bot commented Oct 9, 2024

Automated adapter checker

ioBroker.viessmann

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

👍 No errors found

  • 👀 [S139] Please evaluate whether adapter can be modified to support compact mode
  • 👀 [S522] Please consider migrating to admin 5 UI (jsonConfig).
  • 👀 [W173] Potential sensitive data "password" not listed at "protectedNative" in io-package.json
  • 👀 [W174] Potential sensitive data "password" not listed at "encryptedNative" in io-package.json

Adapter releases: https://www.iobroker.dev/adapter/viessmann/releases
Adapter statistic: https://www.iobroker.dev/adapter/viessmann/statistics

History and usage information for release 1.4.9:

1.4.9 created 9.9.2024 (29 days old)
37 users (5.03%)

1.4.7 (stable) created 13.1.2024 (269 days old)
434 users (stable) (58.97%)

Please verify that this PR really tries to update to release 1.4.9!

Add comment "RE-CHECK!" to start check anew

@github-actions github-actions bot deleted a comment from mcm1957 Oct 9, 2024
@mcm1957 mcm1957 removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. 14.10.2024 labels Oct 9, 2024
@mcm1957 mcm1957 merged commit 9c4403b into ioBroker:master Oct 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias Stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants