Fix bug where you couldn't save after forking a notebook (#1781)

sets notebookInfo.username to be same as userData.name when a notebook is
forked.

CHANGELOG.md

@@ -6,6 +6,7 @@
 - only show notebooks with 10 or more edits on the server's index page list
 - fixes bug where fetch chunks with errors don't halt further evaluation
 - adds `arrayBuffer` type to fetch chunks (see docs)
+- fix bug where you couldn't save a notebook after forking it
 
 # 0.5.0 (2019-03-28)
 

src/editor/actions/actions.js

@@ -246,6 +246,7 @@ export function moveCursorToNextChunk() {
 
 export function createNewNotebookOnServer(options = { forkedFrom: undefined }) {
   return async (dispatch, getState) => {
+    const { forkedFrom } = options;
     const state = getState();
     try {
       const notebook = await createNotebookRequest(
@@ -261,8 +262,16 @@ export function createNewNotebookOnServer(options = { forkedFrom: undefined }) {
         })
       );
       dispatch({ type: "ADD_NOTEBOOK_ID", id: notebook.id });
-      window.history.replaceState({}, "", `/notebooks/${notebook.id}`);
+      window.history.replaceState({}, "", `/notebooks/${notebook.id}/`);
       dispatch({ type: "NOTEBOOK_SAVED" });
+      // update owner info, so we know that we can save
+      if (forkedFrom) {
+        dispatch({
+          type: "SET_NOTEBOOK_OWNER_IN_SESSION",
+          owner: state.userData,
+          forkedFrom
+        });
+      }
     } catch (err) {
       dispatch(
         updateAppMessages({

src/editor/reducers/notebook-reducer.js

@@ -310,6 +310,17 @@ const notebookReducer = (state = newNotebook(), action) => {
       });
     }
 
+    case "SET_NOTEBOOK_OWNER_IN_SESSION": {
+      const { notebookInfo, userData } = state;
+      const newNotebookInfo = Object.assign({}, notebookInfo);
+      newNotebookInfo.username = userData.name;
+      newNotebookInfo.user_can_save = true;
+      newNotebookInfo.files = newNotebookInfo.files.map(f =>
+        Object.assign({}, f)
+      );
+      return Object.assign({}, state, { notebookInfo: newNotebookInfo });
+    }
+
     default: {
       return state;
     }