Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "exists" method to Filer #33

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

pfeairheller
Copy link
Contributor

The PR adds an exists method to Filer that will check for existence of directory or file before "reopen" creates it.

@SmithSamuelM SmithSamuelM merged commit d3aa575 into ioflo:master Apr 3, 2024
2 checks passed
@SmithSamuelM
Copy link
Contributor

@pfeairheller

I accepted the pull request. But in looking more closely at the code for reopen/remake I think that adding a parameter to reopen/remake like virgin=True/False and some logic changes that there would be a way to make it so you could tell if
it ready existed because it would force it to only be opened == True if it was a virgin open (i.e. did not exist before i.e never been opened). But is was going to take more time to figure out than I had so I will come back to it later. This way can also manage the alternate path as well. Created an issue for me to do this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants