Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Fix(state): state reset --plugins|--platforms was resetting both #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakub-g
Copy link

@jakub-g jakub-g commented Feb 17, 2016

fixes ionic-team/ionic-cli#399

I think I broke some unit tests, will update them later this week

@jakub-g
Copy link
Author

jakub-g commented Feb 19, 2016

Updated the PR, added the tests

Now the only tests failing for me are ones reported in #32 and #71 that fail as of today in master

@jakub-g
Copy link
Author

jakub-g commented Apr 14, 2016

Any chance to get this merged?
a number of people are affected, see ionic-team/ionic-cli#399

@tlancina
Copy link
Contributor

Hey @jakub-g thanks for the ping, does your workflow work with the Cordova commands (ie. restoring by running prepare), I believe it shouldn't install plugins if they are already installed.

The reason being that we are considering removing the state command: ionic-team/ionic-cli#904. Would love to hear your input on that issue if this affects a particular use case you have.

@jakub-g
Copy link
Author

jakub-g commented May 31, 2016

Hello,

sorry for late response.

I didn't know that ionic commands were created due to lack of cordova commands, so we went with the "ionic way" in our project (I thought it was the "blessed way" for whatever reason).

It seems indeed there's some confusion as per this SO question, many people are not sure which way to go.

I'll try to check the "cordova way" in my spare time, for now we've invested in some tooling around ionic scripts and it works fine for us.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ionic state reset --plugins resets platforms
2 participants