Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: live reload not deploying app when warnings are present #4807 #5043

Merged
merged 2 commits into from
Dec 20, 2023
Merged

fix: live reload not deploying app when warnings are present #4807 #5043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57b6c57
fix: live reload not deploying app when warnings are present #4807
Oct 6, 2023
9dbdc14
Merge branch 'develop' into fix-live-reload-vue-service-4807
liamdebeasi Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@ionic/cli/src/lib/project/react/serve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export class ReactServeCLI extends ServeCLI<ReactServeOptions> {

const strippedLine = stripAnsi(line);

const compileMsgs = ['Compiled successfully', 'Compiled with warnings', 'Failed to compile'];
const compileMsgs = ['Compiled successfully', 'Compiled with', 'Failed to compile'];
if (compileMsgs.some(msg => strippedLine.includes(msg))) {
this.emit('ready');
return false;
Expand Down
2 changes: 1 addition & 1 deletion packages/@ionic/cli/src/lib/project/vue/serve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export class VueServeCLI extends ServeCLI<VueServeOptions> {
}

const strippedLine = stripAnsi(line);
const compileMsgs = ['Compiled successfully', 'Compiled with warnings', 'Failed to compile'];
const compileMsgs = ['Compiled successfully', 'Compiled with', 'Failed to compile'];
if (compileMsgs.some(msg => strippedLine.includes(msg))) {
this.emit('ready');
return false;
Expand Down