Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate the ssl command #5068

Merged
merged 5 commits into from
Jan 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/@ionic/cli/src/commands/ssl/generate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ Uses OpenSSL to create a self-signed certificate for ${strong('localhost')} (by
After the certificate is generated, you will still need to add it to your system or browser as a trusted certificate.

The default directory for ${input('--key-path')} and ${input('--cert-path')} is ${input('.ionic/ssl/')}.

Deprecated. Developers should generate an SSL certificate locally and then configure it using their project tooling such as Vite or Angular CLI.
`,
options: [
{
Expand Down Expand Up @@ -110,7 +112,7 @@ The default directory for ${input('--key-path')} and ${input('--cert-path')} is
groups: [MetadataGroup.ADVANCED],
},
],
groups: [MetadataGroup.EXPERIMENTAL],
groups: [MetadataGroup.DEPRECATED],
};
}

Expand Down
2 changes: 1 addition & 1 deletion packages/@ionic/cli/src/commands/ssl/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export class SSLNamespace extends Namespace {
return {
name: 'ssl',
summary: 'Commands for managing SSL keys & certificates',
groups: [MetadataGroup.EXPERIMENTAL],
groups: [MetadataGroup.DEPRECATED],
description: `
These commands make it easy to manage SSL certificates for using HTTPS with ${input('ionic serve')}.
`,
Expand Down